SteNicholas opened a new pull request, #2880: URL: https://github.com/apache/celeborn/pull/2880
### What changes were proposed in this pull request? Fix `WARNING` of error prone. ### Why are the changes needed? There are many `WARNING` generated by error prone. We should follow the suggestion of error prone to fix `WARNING`. ``` $ mvn clean install -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep "[WARNING]"|grep java [WARNING] /Users/nicholas/Github/celeborn/common/src/test/java/org/apache/celeborn/common/network/sasl/SaslTestBase.java:[100,8] [Finally] If you return or throw from a finally, then values returned or thrown from the try-catch block will be ignored. Consider using try-with-resources instead. [WARNING] /Users/nicholas/Github/celeborn/common/src/test/java/org/apache/celeborn/common/client/MasterClientSuiteJ.java:[207,10] [AssertionFailureIgnored] This assertion throws an AssertionError if it fails, which will be caught by an enclosing try block. /Users/nicholas/Github/celeborn/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:[635,17] [MissingOverride] reportBarrierTaskFailure implements method in ShuffleClient; expected @Override /Users/nicholas/Github/celeborn/client/src/test/java/org/apache/celeborn/client/DummyShuffleClient.java:[186,17] [MissingOverride] reportBarrierTaskFailure implements method in ShuffleClient; expected @Override /Users/nicholas/Github/celeborn/worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/RecyclableSegmentIdBuffer.java:[37,17] [MissingOverride] isDataBuffer overrides method in RecyclableBuffer; expected @Override [WARNING] /Users/nicholas/Github/celeborn/worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/segment/SegmentMapPartitionDataReader.java:[281,16] [OperatorPrecedence] Use grouping parenthesis to make the operator precedence explicit [WARNING] /Users/nicholas/Github/celeborn/worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/segment/SegmentMapPartitionDataReader.java:[299,24] [MissingOverride] generateReadDataMessage overrides method in MapPartitionDataReader; expected @Override ``` ``` $ mvn clean install -Pflink-1.20 -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep "[WARNING]"|grep java [WARNING] /Users/nicholas/Github/celeborn/client-flink/common/src/test/java/org/apache/celeborn/plugin/flink/network/TransportFrameDecoderWithBufferSupplierSuiteJ.java:[143,75] [ModifiedButNotUsed] A collection or proto builder was created, but its values were never accessed. [WARNING] /Users/nicholas/Github/celeborn/client-flink/flink-1.20/src/test/java/org/apache/celeborn/plugin/flink/RemoteShuffleResultPartitionSuiteJ.java:[143,67] [CanonicalDuration] Duration can be expressed more clearly with different units ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual test. ``` $ mvn clean install -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep WARNING|grep java $ mvn clean install -Pspark-2.4 -pl client-spark/common,client-spark/spark-2 -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep WARNING|grep java $ mvn clean install -Pspark-3.5 -pl client-spark/spark-3 -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep WARNING|grep java $ mvn clean install -Pflink-1.14 -pl client-flink/common,client-flink/flink-1.14 -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep WARNING|grep java $ mvn clean install -Pflink-1.15 -pl client-flink/flink-1.15 -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep WARNING|grep java $ mvn clean install -Pflink-1.16 -pl client-flink/flink-1.16 -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep WARNING|grep java $ mvn clean install -Pflink-1.17 -pl client-flink/flink-1.17 -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep WARNING|grep java $ mvn clean install -Pflink-1.18 -pl client-flink/flink-1.18 -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep WARNING|grep java $ mvn clean install -Pflink-1.19 -pl client-flink/flink-1.19 -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep WARNING|grep java $ mvn clean install -Pflink-1.20 -pl client-flink/flink-1.20 -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep WARNING|grep java $ mvn clean install -Pmr -pl client-mr/mr -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true|grep WARNING|grep java ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
