zhaohehuhu commented on code in PR #2830:
URL: https://github.com/apache/celeborn/pull/2830#discussion_r1843251599
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java:
##########
@@ -264,7 +299,9 @@ public void flush(boolean finalFlush, boolean fromEvict)
throws IOException {
} else if (diskFileInfo.isHdfs()) {
task = new HdfsFlushTask(flushBuffer, diskFileInfo.getDfsPath(),
notifier, true);
} else if (diskFileInfo.isS3()) {
- task = new S3FlushTask(flushBuffer, diskFileInfo.getDfsPath(),
notifier, true);
+ task =
+ new S3FlushTask(
+ flushBuffer, notifier, true, s3MultipartUploadHandler,
partNumber);
Review Comment:
done
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java:
##########
@@ -273,6 +310,7 @@ public void flush(boolean finalFlush, boolean fromEvict)
throws IOException {
if (task != null) {
addTask(task);
flushBuffer = null;
+ partNumber++;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
