zwangsheng opened a new pull request, #2985:
URL: https://github.com/apache/celeborn/pull/2985
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Refactoring shuffleWriters, extract common methods as BasedShuffleWriter.
### Why are the changes needed?
Currently, HashBasedShuffleWriter and SortBasedShuffleWriter have a lot of
the same methods, which makes it difficult for us to maintain the code. In many
scenarios, we need to update multiple classes at the same time.
Therefore, we need to refactor Shuffle Writer, extract common methods
without changing the specific method logic, and simplify the corresponding
Shuffle Writer.
### Does this PR introduce _any_ user-facing change?
No, we do not change the logic code of apis or others.
### How was this patch tested?
UT and local env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
