zaynt4606 commented on code in PR #2984:
URL: https://github.com/apache/celeborn/pull/2984#discussion_r1877710847
##########
worker/src/test/scala/org/apache/celeborn/service/deploy/MiniClusterFeature.scala:
##########
@@ -226,12 +226,14 @@ trait MiniClusterFeature extends Logging {
{
if (workers(i) == null) {
throw new IllegalStateException(s"worker $i hasn't been
initialized")
- } else {
+ } else if (!workerInfos.contains(workers(i))) {
workerInfos.put(workers(i), threads(i))
}
+ if (!workers(i).registered.get()) {
+ throw new IllegalStateException(s"worker $i hasn't been
registered")
+ }
}
}
- workerInfos.foreach { case (worker, _) =>
assert(worker.registered.get()) }
allWorkersStarted = true
} catch {
case ex: Throwable =>
Review Comment:
The wait logic is here~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
