SteNicholas commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1882262548


##########
common/src/main/java/org/apache/celeborn/common/network/server/TransportServer.java:
##########
@@ -100,6 +101,7 @@ private void init(String hostToBind, int portToBind) {
             .channel(NettyUtils.getServerChannelClass(ioMode))
             .option(ChannelOption.ALLOCATOR, allocator)
             .option(ChannelOption.SO_REUSEADDR, !SystemUtils.IS_OS_WINDOWS)
+            .option(EpollChannelOption.SO_REUSEPORT, 
IOMode.EPOLL.equals(ioMode))

Review Comment:
   The test case `port conflict` has exception that 
`io.netty.channel.unix.Errors$NativeIoException: bind(..)` for epoll io mode. 
Therefore, we could set `EpollChannelOption.SO_REUSEPORT` to true for epoll io 
mode to avoid exception of port conflict.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to