RexXiong commented on code in PR #2989:
URL: https://github.com/apache/celeborn/pull/2989#discussion_r1883342108
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -374,7 +375,7 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
logError(
s"PushData replication failed during connecting peer for
partitionLocation: $location",
e)
- callbackWithTimer.onFailure(
+ wrappedCallback.onFailure(
Review Comment:
ditto
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -719,7 +720,7 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
logError(
s"PushMergedData replication failed during connecting peer for
partitionLocation: $location",
e)
- pushMergedDataCallback.onFailure(
+ wrappedCallback.onFailure(
Review Comment:
should keep pushMergedDataCallback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
