RexXiong commented on code in PR #2990:
URL: https://github.com/apache/celeborn/pull/2990#discussion_r1887842276
##########
common/src/main/scala/org/apache/celeborn/common/metrics/source/Role.scala:
##########
@@ -20,4 +20,5 @@ package org.apache.celeborn.common.metrics.source
object Role {
val MASTER = "master"
val WORKER = "worker"
+ val RPC = "rpc"
Review Comment:
I believe that the role names should represent a single process. Therefore,
it would be more appropriate to use MASTER, WORKER, and CLIENT instead of RPC,
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
