SteNicholas commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1887931876
##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -328,8 +328,7 @@ object Utils extends Logging {
}
isBindCollision(e.getCause)
case e: NativeIoException =>
- (e.getMessage != null && e.getMessage.startsWith("bind() failed: ")) ||
- isBindCollision(e.getCause)
+ e.getMessage != null && e.getMessage.startsWith("bind")
Review Comment:
@turboFei, IMO, according to constructor of `NativeIoException`,
`NativeIoException` has no cause and the message could only check whether
message contains the `method` which is `bind`.
```
public NativeIoException(String method, int expectedErr) {
this(method, expectedErr, true);
}
public NativeIoException(String method, int expectedErr, boolean
fillInStackTrace) {
super(method + "(..) failed: " + errnoString(-expectedErr));
this.expectedErr = expectedErr;
this.fillInStackTrace = fillInStackTrace;
}
```
The exception message is `io.netty.channel.unix.Errors$NativeIoException:
bind(..) failed: Address already in use`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
