mridulm commented on code in PR #2813:
URL: https://github.com/apache/celeborn/pull/2813#discussion_r1894330333
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/http/api/v1/WorkerResource.scala:
##########
@@ -151,8 +151,8 @@ class WorkerResource extends ApiRequestContext {
new HandleResponse().success(success).message(finalMsg)
}
- private def toWorkerEventType(enum: EventTypeEnum): WorkerEventType = {
- enum match {
+ private def toWorkerEventType(eunmObj: EventTypeEnum): WorkerEventType = {
+ eunmObj match {
Review Comment:
I have been bitten by this with scala update :)
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -664,7 +664,7 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
pushMergedDataCallback.onSuccess(StatusCode.SUCCESS)
}
}
- case None =>
+ case Some(_) | None =>
Review Comment:
From a code pov: `case _` ? (same for below).
I will need to look at why this is happening out of band though :)
(If you can drop a note on why, that would be great and would save me some
time, thanks !)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
