s0nskar commented on code in PR #3020: URL: https://github.com/apache/celeborn/pull/3020#discussion_r1894550867
##########
docs/configuration/index.md:
##########
@@ -138,21 +138,22 @@ end="<!--end-include-->"
Recommend configuring in `conf/celeborn-env.sh`.
-| Key | Default
| Description |
-|----------------------------------|-------------------------------------------------|--------------------------------------------------------|
-| `CELEBORN_HOME` | ``$(cd "`dirname "$0"`"/..; pwd)``
| |
-| `CELEBORN_CONF_DIR` |
`${CELEBORN_CONF_DIR:-"${CELEBORN_HOME}/conf"}` |
|
-| `CELEBORN_MASTER_MEMORY` | 1 GB
| |
-| `CELEBORN_WORKER_MEMORY` | 1 GB
| |
-| `CELEBORN_WORKER_OFFHEAP_MEMORY` | 1 GB
| |
-| `CELEBORN_MASTER_JAVA_OPTS` |
| |
-| `CELEBORN_WORKER_JAVA_OPTS` |
| |
-| `CELEBORN_PID_DIR` | `${CELEBORN_HOME}/pids`
| |
-| `CELEBORN_LOG_DIR` | `${CELEBORN_HOME}/logs`
| |
-| `CELEBORN_SSH_OPTS` | `-o StrictHostKeyChecking=no`
| |
-| `CELEBORN_SLEEP` |
| Waiting time for `start-all` and `stop-all` operations |
-| `CELEBORN_PREFER_JEMALLOC` |
| set `true` to enable jemalloc memory allocator |
-| `CELEBORN_JEMALLOC_PATH` |
| jemalloc library path |
+| Key | Default
| Description |
+|----------------------------------|-------------------------------------------------|-----------------------------------------------------------|
+| `CELEBORN_HOME` | ``$(cd "`dirname "$0"`"/..; pwd)``
| |
+| `CELEBORN_CONF_DIR` |
`${CELEBORN_CONF_DIR:-"${CELEBORN_HOME}/conf"}` |
|
+| `CELEBORN_MASTER_MEMORY` | 1 GB
| |
+| `CELEBORN_WORKER_MEMORY` | 1 GB
| |
+| `CELEBORN_WORKER_OFFHEAP_MEMORY` | 1 GB
| |
+| `CELEBORN_MASTER_JAVA_OPTS` |
| |
+| `CELEBORN_WORKER_JAVA_OPTS` |
| |
+| `CELEBORN_PID_DIR` | `${CELEBORN_HOME}/pids`
| |
+| `CELEBORN_LOG_DIR` | `${CELEBORN_HOME}/logs`
| |
+| `CELEBORN_SSH_OPTS` | `-o StrictHostKeyChecking=no`
| |
+| `CELEBORN_SLEEP` |
| Waiting time for `start-all` and `stop-all` operations |
+| `CELEBORN_PREFER_JEMALLOC` |
| set `true` to enable jemalloc memory allocator |
+| `CELEBORN_JEMALLOC_PATH` |
| jemalloc library path |
+| `CELEBORN_NO_DAEMONIZE` |
| set `true` to run the proposed command in the foreground. |
Review Comment:
Done, added other missing variables as well. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
