turboFei commented on code in PR #3022:
URL: https://github.com/apache/celeborn/pull/3022#discussion_r1895991656
##########
openapi/openapi-client/src/main/openapi3/master_rest_v1.yaml:
##########
@@ -456,6 +456,44 @@ paths:
type: string
format: binary
+ /api/v1/logger:
Review Comment:
`loggerContext.getLoggers` returns all the logger instances level, I am
afraid that there might be too many loggers to return in production.
And I think`loggerContext.getConfiguration.getLoggers` is more reasonable.
It only return the configured logger, including the items in the config file
and changed by `POST /api/v1/loggers`, and it is more clear in user prospect.
https://github.com/apache/celeborn/blob/680b072b5bea852e8cf7733f0ec4d8aea127c51f/common/src/test/resources/log4j2-test.xml#L31-L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
