turboFei commented on code in PR #3030:
URL: https://github.com/apache/celeborn/pull/3030#discussion_r1897089777
##########
sbin/celeborn-daemon.sh:
##########
@@ -166,6 +166,11 @@ run_command() {
}
start_celeborn() {
+ if [ ! -d "$CELEBORN_CONF_DIR" ]
+ then
+ echo "ERROR : CELEBORN_CONF_DIR: $CELEBORN_CONF_DIR is not a directory"
+ exit 1
+ fi
Review Comment:
The celeborn-daemon.sh would load the celenorn-env.sh after checking the
`--config` option.
https://github.com/apache/celeborn/blob/fde6365f68ce8b589bcc639e96476ed618249257/sbin/celeborn-daemon.sh#L79
So we just check it before run the start command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
