FMX commented on PR #3028: URL: https://github.com/apache/celeborn/pull/3028#issuecomment-2564720004
> do you plan to have 2 modules likes other clients? > > ``` > client-tez/tez > client-tez/tez-shaded > ``` > > And could you enable the `tez` dependency check? https://github.com/apache/celeborn/blob/main/dev/dependencies.sh https://github.com/apache/celeborn/blob/main/.github/workflows/deps.yml > > Also, it is better to provide the checking result for the shaded jar. > > ``` > jar -tf $SHADED_JAR | grep -v celeborn | grep '\.class$' > ``` I've updated this PR. The dep check for SBT will come up with a new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
