FMX commented on code in PR #3056:
URL: https://github.com/apache/celeborn/pull/3056#discussion_r1908196010
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -1059,7 +1059,9 @@ public void onFailure(Throwable e) {
@Override
public void updateLatestPartition(PartitionLocation newloc) {
pushState.addBatch(nextBatchId, newloc.hostAndPushPort());
Review Comment:
The method `addBatch` will increment totalInflightReqs, but you skipped the
`removeBatch` call, which means the totalInflightReqs can not be zero.
That's why the CI failed a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
