turboFei commented on code in PR #3064:
URL: https://github.com/apache/celeborn/pull/3064#discussion_r1914005368
##########
common/src/main/scala/org/apache/celeborn/common/util/ThreadUtils.scala:
##########
@@ -122,8 +122,15 @@ object ThreadUtils {
* Create a thread factory that names threads with a prefix and also sets
the threads to daemon.
*/
def namedThreadFactory(threadNamePrefix: String): ThreadFactory = {
+ namedThreadFactory(threadNamePrefix, daemon = true)
+ }
+
+ /**
+ * Create a thread factory that names threads with a prefix and also sets
the threads to daemon.
Review Comment:
Nit: the method description is same with that of above `namedThreadFactory`.
We should clarify it.
```
* Creates a ThreadFactory that generates threads with a specified name
prefix and daemon setting.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
