RexXiong commented on code in PR #3079:
URL: https://github.com/apache/celeborn/pull/3079#discussion_r1924641480
##########
client/src/main/java/org/apache/celeborn/client/read/CelebornInputStream.java:
##########
@@ -322,14 +324,10 @@ private boolean isExcluded(PartitionLocation location) {
private PartitionReader createReaderWithRetry(
PartitionLocation location, PbStreamHandler pbStreamHandler) throws
IOException {
- // For the first time, the location will be selected according to
attemptNumber
- if (fetchChunkRetryCnt == 0 && attemptNumber % 2 == 1 &&
location.hasPeer()) {
- location = location.getPeer();
- logger.debug("Read peer {} for attempt {}.", location, attemptNumber);
- }
Exception lastException = null;
Review Comment:
IMO, It would be better keep this, switch peers based on the attemptNumber,
may avoid failure PartitionLocation previously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
