turboFei commented on code in PR #3080:
URL: https://github.com/apache/celeborn/pull/3080#discussion_r1925434478
##########
client-spark/spark-3-4/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleReader.scala:
##########
@@ -370,7 +376,22 @@ class CelebornShuffleReader[K, C](
}
}
- private def handleFetchExceptions(
+ @VisibleForTesting
+ def checkAndReportFetchFailureForUpdateFileGroupFailure(
+ celebornShuffleId: Int,
+ ce: Throwable): Unit = {
+ if (ce.getCause != null &&
+ (ce.getCause.isInstanceOf[InterruptedException] ||
ce.getCause.isInstanceOf[
Review Comment:
Here for the `InterruptedException`, even
https://github.com/apache/celeborn/pull/2921 can handle it.
But this PR is more efficient, it do not need to talk with driver and
prevent the stage-run for `InterruptedException` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
