s0nskar opened a new pull request, #3086:
URL: https://github.com/apache/celeborn/pull/3086
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Setup worker endpoint after initalizing the controller.
### Why are the changes needed?
In current flow controller rpc endpoint is setup before calling the
`controller.init(this)` leaving the required members to be unintialized which
leading to lot of NullPointer exception in worker during restarts.
```
10:53:55.262 [celeborn-dispatcher-6] ERROR
org.apache.celeborn.common.rpc.netty.Inbox - Ignoring error
java.lang.NullPointerException: null
at
org.apache.celeborn.service.deploy.worker.Controller.org$apache$celeborn$service$deploy$worker$Controller$$handleDestroy(Controller.scala:659)
~[celeborn-worker_2.12-0.5.3.jar:0.5.3]
at
org.apache.celeborn.service.deploy.worker.Controller$$anonfun$receiveAndReply$1.applyOrElse(Controller.scala:143)
~[celeborn-worker_2.12-0.5.3.jar:0.5.3]
at
org.apache.celeborn.common.rpc.netty.Inbox.processInternal(Inbox.scala:119)
~[celeborn-common_2.12-0.5.3.jar:0.5.3]
at
org.apache.celeborn.common.rpc.netty.Inbox.$anonfun$process$1(Inbox.scala:218)
~[celeborn-common_2.12-0.5.3.jar:0.5.3]
at
org.apache.celeborn.common.rpc.netty.Inbox.safelyCall(Inbox.scala:314)
~[celeborn-common_2.12-0.5.3.jar:0.5.3]
at org.apache.celeborn.common.rpc.netty.Inbox.process(Inbox.scala:218)
~[celeborn-common_2.12-0.5.3.jar:0.5.3]
at
org.apache.celeborn.common.rpc.netty.Dispatcher$MessageLoop.run(Dispatcher.scala:238)
~[celeborn-common_2.12-0.5.3.jar:0.5.3]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
~[?:1.8.0_412]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
~[?:1.8.0_412]
at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_412]
10:53:55.570 [main] INFO org.apache.celeborn.service.deploy.worker.Worker -
Register worker successfully.
10:53:55.573 [main] INFO org.apache.celeborn.service.deploy.worker.Worker -
Worker started.
```
### Does this PR introduce _any_ user-facing change?
NA
### How was this patch tested?
Existing UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
