s0nskar commented on code in PR #3089:
URL: https://github.com/apache/celeborn/pull/3089#discussion_r1948582097
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -379,7 +379,7 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
}
causes.add(Utils.toStatusCode(info.getStatus))
}
- logWarning(s"Received Revive request, number of partitions
${partitionIds.size()}")
+ logDebug(s"Received Revive request, number of partitions
${partitionIds.size()}")
Review Comment:
@FMX These logs gets print very often – example for a small test application
i am running driver logs have around 40K lines of this exact log – which is not
very useful for any debugging. This code flow will anyway trigger the
ChangePartitionManager flow which will print the log consolidating these revive
request.
```
ChangePartitionManager: Batch handle change partition for [0-0-0,0-3-0]
```
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -379,7 +379,7 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
}
causes.add(Utils.toStatusCode(info.getStatus))
}
- logWarning(s"Received Revive request, number of partitions
${partitionIds.size()}")
+ logDebug(s"Received Revive request, number of partitions
${partitionIds.size()}")
Review Comment:
@FMX These logs gets print very often – example for a small test application
i am running, driver logs have around 40K lines of this exact log – which is
not very useful for any debugging. This code flow will anyway trigger the
ChangePartitionManager flow which will print the log consolidating these revive
request.
```
ChangePartitionManager: Batch handle change partition for [0-0-0,0-3-0]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
