onebox-li commented on code in PR #3079:
URL: https://github.com/apache/celeborn/pull/3079#discussion_r1952122916
##########
client/src/main/java/org/apache/celeborn/client/read/CelebornInputStream.java:
##########
@@ -351,6 +349,28 @@ private PartitionReader createReaderWithRetry(
location,
e);
location = location.getPeer();
+ if (pbStreamHandler != null) {
+ try {
+ TransportClient client =
+ clientFactory.createClient(location.getHost(),
location.getFetchPort());
+ TransportMessage bufferStreamEnd =
+ new TransportMessage(
+ MessageType.BUFFER_STREAM_END,
Review Comment:
Sorry for late reply. IIRC, streamHandlers are created in advance. If the
location is excluded when fetching and streamHandler is not null, it should
have been opened to the worker before. However, we may need to improve safe use
of streamHandler in some scenarios such as worker restart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
