turboFei commented on code in PR #3096:
URL: https://github.com/apache/celeborn/pull/3096#discussion_r1953516408
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -3070,6 +3079,18 @@ object CelebornConf extends Logging {
.intConf
.createWithDefault(16)
+ val WORKER_STORAGE_BASE_DIR_DISK_TYPE: ConfigEntry[String] =
+ buildConf("celeborn.worker.storage.baseDir.diskType")
+ .internal
+ .categories("worker")
+ .version("0.6.0")
+ .doc(
+ s"The disk type of base directory for worker. Available options:
${StorageInfo.Type.HDD.name}, ${StorageInfo.Type.SSD.name}.")
Review Comment:
nit: IIUC
```
It only works if ${WORKER_STORAGE_DIRS.key}` is not set.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
