SteNicholas commented on code in PR #3102:
URL: https://github.com/apache/celeborn/pull/3102#discussion_r1958082119
##########
client-flink/flink-1.20/src/main/java/org/apache/celeborn/plugin/flink/tiered/CelebornChannelBufferReader.java:
##########
@@ -124,7 +124,9 @@ public CelebornChannelBufferReader(
public void setup(TieredStorageMemoryManager memoryManager) {
this.bufferManager = new CelebornChannelBufferManager(memoryManager, this);
if (numBackLog > 0) {
- notifyAvailableCredits(bufferManager.requestBuffers(numBackLog));
+ int numRequestedBuffers = bufferManager.requestBuffers(numBackLog);
Review Comment:
Does this need to check whether `numRequestedBuffers` is greater than 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
