SteNicholas commented on code in PR #3120:
URL: https://github.com/apache/celeborn/pull/3120#discussion_r1972731046
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -6084,6 +6091,18 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(false)
+ val SSL_HANDSHAKE_TIMEOUT_MS: ConfigEntry[Long] =
+ buildConf("celeborn.ssl.<module>.sslHandshakeTimeoutMs")
Review Comment:
Is `celeborn.ssl.<module>.sslHandshakeTimeoutMs` better to be internal?
Because `celeborn.ssl.<module>.autoSslEnabled` is internal. BTW, the internal
config option isn't generated in document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
