SteNicholas commented on code in PR #3120:
URL: https://github.com/apache/celeborn/pull/3120#discussion_r1972997439


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -6084,6 +6091,18 @@ object CelebornConf extends Logging {
       .booleanConf
       .createWithDefault(false)
 
+  val SSL_HANDSHAKE_TIMEOUT_MS: ConfigEntry[Long] =
+    buildConf("celeborn.ssl.<module>.sslHandshakeTimeoutMs")
+      .categories("network", "ssl")
+      .version("0.6.0")
+      .doc("The timeout for the SSL handshake (in milliseconds). The default 
value is set to " +

Review Comment:
   @rmcyang, I mean that you should add the description in this `doc` to help 
user which modules this config option could specify via configuration document.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to