RexXiong commented on code in PR #3135:
URL: https://github.com/apache/celeborn/pull/3135#discussion_r1993185955
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -145,6 +145,7 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
locations: util.List[PartitionLocation]): Unit = {
val map = latestPartitionLocation.computeIfAbsent(shuffleId, newMapFunc)
locations.asScala.foreach(location => map.put(location.getId, location))
+ invalidateLatestMaxLocsCache(shuffleId)
Review Comment:
Since cache invalidate when location updated, so we can consider extending
rpcCacheExpireTime to a longer duration, such as `60s`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]