ChenYi015 commented on code in PR #3182:
URL: https://github.com/apache/celeborn/pull/3182#discussion_r2018243646
##########
charts/celeborn/templates/configmap.yaml:
##########
@@ -50,89 +50,7 @@ data:
{{- end}}
log4j2.xml: |-
- <?xml version="1.0" encoding="UTF-8"?>
- <!--
- ~ Licensed to the Apache Software Foundation (ASF) under one or more
- ~ contributor license agreements. See the NOTICE file distributed with
- ~ this work for additional information regarding copyright ownership.
- ~ The ASF licenses this file to You under the Apache License, Version 2.0
- ~ (the "License"); you may not use this file except in compliance with
- ~ the License. You may obtain a copy of the License at
- ~
- ~ http://www.apache.org/licenses/LICENSE-2.0
- ~
- ~ Unless required by applicable law or agreed to in writing, software
- ~ distributed under the License is distributed on an "AS IS" BASIS,
- ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- ~ See the License for the specific language governing permissions and
- ~ limitations under the License.
- -->
- <!--
- ~ Extra logging related to initialization of Log4j.
- ~ Set to debug or trace if log4j initialization is failing.
- -->
- <Configuration status="INFO">
- <Appenders>
- <Console name="stdout" target="SYSTEM_OUT">
- <!--
- ~ In the pattern layout configuration below, we specify an
explicit `%ex` conversion
- ~ pattern for logging Throwables. If this was omitted, then
(by default) Log4J would
- ~ implicitly add an `%xEx` conversion pattern which logs
stacktraces with additional
- ~ class packaging information. That extra information can
sometimes add a substantial
- ~ performance overhead, so we disable it in our default
logging config.
- -->
- <PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t]
%c{1}: %m%n%ex"/>
- </Console>
- <RollingRandomAccessFile name="file"
fileName="${env:CELEBORN_LOG_DIR}/celeborn.log"
-
filePattern="${env:CELEBORN_LOG_DIR}/celeborn.log.%d-%i">
- <PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t]
%c{1}: %m%n%ex"/>
- <Policies>
- <SizeBasedTriggeringPolicy size="200 MB"/>
- </Policies>
- <DefaultRolloverStrategy max="7">
- <Delete basePath="${env:CELEBORN_LOG_DIR}" maxDepth="1">
- <IfFileName glob="celeborn.log*">
- <IfAny>
- <IfAccumulatedFileSize exceeds="1 GB" />
- <IfAccumulatedFileCount exceeds="10" />
- </IfAny>
- </IfFileName>
- </Delete>
- </DefaultRolloverStrategy>
- </RollingRandomAccessFile>
- <RollingRandomAccessFile name="restAuditFile"
fileName="${env:CELEBORN_LOG_DIR}/audit/rest-audit.log"
-
filePattern="${env:CELEBORN_LOG_DIR}/audit/rest-audit.log.%d-%i">
- <PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t]
%c{1}: %m%n%ex"/>
- <Policies>
- <SizeBasedTriggeringPolicy size="200 MB"/>
- </Policies>
- <DefaultRolloverStrategy max="7">
- <Delete basePath="${env:CELEBORN_LOG_DIR}/audit"
maxDepth="1">
- <IfFileName glob="rest-audit.log*">
- <IfAny>
- <IfAccumulatedFileSize exceeds="1 GB"/>
- <IfAccumulatedFileCount exceeds="10"/>
- </IfAny>
- </IfFileName>
- </Delete>
- </DefaultRolloverStrategy>
- </RollingRandomAccessFile>
- </Appenders>
+ {{- .Files.Get "files/conf/log4j2.xml" | nindent 4 }}
Review Comment:
What about skipping mounting these configuration files and just use the
configuration files bundled in the Celeborn image by default? I will update the
docs to guide users how to customize logging and metrics by creating ConfigMap
from local files and mounting these files into Celeborn pods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
