pan3793 commented on PR #3177: URL: https://github.com/apache/celeborn/pull/3177#issuecomment-2769291044
@HolyLow I agree with all your points, except to > we choose to use different serialisation for different language, marked by the first byte. If I understand correctly, your proposed new serialization layout should be language-agnostic, right? If so, why mark it as exclusive to cpp? For backward compatibility, as you said, there are sufficient characteristics for Java serialization to allow the deserializer to recognize(correct me if I am wrong), why an extra byte is required for the new serialization layout? Can we just use a raw protobuf layout? > the existing java serialisation invokes java-related serialisation stack, and the java messeges including class hierarchy, magic number, versioning are deeply involved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
