RexXiong commented on code in PR #3192:
URL: https://github.com/apache/celeborn/pull/3192#discussion_r2040494447
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4036,6 +4039,15 @@ object CelebornConf extends Logging {
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("64k")
+ val PARTITION_READER_CHECKPOINT_ENABLED: ConfigEntry[Boolean] =
+ buildConf("celeborn.client.partition.reader.checkpoint.enabled")
+ .categories("client")
+ .version("0.6.0")
Review Comment:
nit: should be 0.5.5, also need change main branch to 0.5.5
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4036,6 +4039,15 @@ object CelebornConf extends Logging {
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("64k")
+ val PARTITION_READER_CHECKPOINT_ENABLED: ConfigEntry[Boolean] =
+ buildConf("celeborn.client.partition.reader.checkpoint.enabled")
+ .categories("client")
+ .version("0.6.0")
+ .doc("Whether or not checkpoint reads when re-creating a partition
reader. Setting to true minimizes" +
+ " the amount of unnecessary reads during partition read retries")
+ .booleanConf
+ .createWithDefault(false)
Review Comment:
We can consider enabling it by default, as it doesn't seem to introduce much
overhead. WDYT？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
