FMX commented on code in PR #3215:
URL: https://github.com/apache/celeborn/pull/3215#discussion_r2049921991
##########
common/src/main/java/org/apache/celeborn/common/protocol/message/StatusCode.java:
##########
@@ -112,4 +112,9 @@ public static StatusCode fromValue(byte value) {
}
throw new IllegalArgumentException("Unknown status code: " + value);
}
+
+ public static StatusCode fromValue(int value) {
+ assert (value >= 0 && value < 256);
Review Comment:
There is no '—ea ' in the scripts of starting workers and masters, so this
assertion won't have any effect.
If you intend to make sure this check is correct, use `Preconditions`
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
