ashangit opened a new pull request, #3223:
URL: https://github.com/apache/celeborn/pull/3223
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Add help/type on prometheus exposed metrics:
```
# HELP metrics_UpdateResourceConsumptionTime_Count
# TYPE metrics_UpdateResourceConsumptionTime_Count counter
metrics_UpdateResourceConsumptionTime_Count{instance="192.168.192.143:9098",role="master"}
1 1745390288743
```
### Why are the changes needed?
Datadog agent rely on this type to discover the type of the exposed
prometheus metrics:
https://docs.datadoghq.com/integrations/openmetrics/#missing-untyped-metrics
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Started one master and worker celeborn instance with below
metrics.properties config:
```
*.sink.prometheusServlet.class=org.apache.celeborn.common.metrics.sink.PrometheusServlet
*.sink.jsonServlet.class=org.apache.celeborn.common.metrics.sink.JsonServlet
```
Then connected to the master and worker metrics endpoint for prometheus.
All the metrics now have the help/type annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
