pan3793 commented on code in PR #3071:
URL: https://github.com/apache/celeborn/pull/3071#discussion_r2058235920
##########
common/src/main/java/org/apache/celeborn/common/network/util/NettyUtils.java:
##########
@@ -56,13 +59,25 @@ public static ThreadFactory createThreadFactory(String
threadPoolPrefix) {
return new DefaultThreadFactory(threadPoolPrefix, true);
}
- /** Creates a Netty EventLoopGroup based on the IOMode. */
public static EventLoopGroup createEventLoop(IOMode mode, int numThreads,
String threadPrefix) {
+ return createEventLoop(mode, numThreads, false, threadPrefix);
+ }
+
+ /** Creates a Netty EventLoopGroup based on the IOMode. */
+ public static EventLoopGroup createEventLoop(
+ IOMode mode, int numThreads, boolean conflictAvoidChooserEnable, String
threadPrefix) {
ThreadFactory threadFactory = createThreadFactory(threadPrefix);
switch (mode) {
case NIO:
- return new NioEventLoopGroup(numThreads, threadFactory);
+ return conflictAvoidChooserEnable
Review Comment:
so the issue only happens on NIO mode? seems the PR description hasn't
reflected it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
