ChenYi015 commented on code in PR #3227:
URL: https://github.com/apache/celeborn/pull/3227#discussion_r2063175968


##########
charts/celeborn/templates/configmap.yaml:
##########
@@ -44,11 +44,6 @@ data:
     {{ $key }}={{ $val }}
     {{- end }}
 
-  celeborn-env.sh: |
-    {{- range $key, $val := .Values.environments }}
-    {{ $key }}="{{ $val }}"
-    {{- end}} 

Review Comment:
   Have renamed `environments` to `master.env` and `worker.env` in 
[CELEBORN-1980](https://issues.apache.org/jira/browse/CELEBORN-1980). So 
`celeborn-env.sh` is not needed anymore for  that we can configure container 
environment variables directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to