vastian180 commented on PR #3240: URL: https://github.com/apache/celeborn/pull/3240#issuecomment-2853464677
ping @onebox-li ，I would like to ask for your advice~ I noticed that in this PR [[CELEBORN-1083] Refine TimeSlidingHub code](https://github.com/apache/celeborn/pull/2033/files#diff-c85b7ab1807b2bc925b8e56f73fd810fc8e4ce6a7f4f13acfb191c53e20054c4) , the clone operation on newNode was removed when calling _deque.add. What was the consideration behind this change? It seems that this could cause issues in scenarios like the following code: that is, multiple BufferStatusHubs add the same node. https://github.com/apache/celeborn/blob/main/worker/src/main/java/org/apache/celeborn/service/deploy/worker/congestcontrol/UserCongestionControlContext.java#L70 Therefore, I submitted this PR to fix this usage issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
