littlexyw commented on PR #3224: URL: https://github.com/apache/celeborn/pull/3224#issuecomment-2856910848
> For > > https://github.com/apache/celeborn/blob/a2110568f279c2714600b31e05708b7cb76e9936/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala#L317-L330 > > We should not call `MemoryManager.instance.releaseMemoryFileStorage(buf.readableBytes())` in L323? > > https://github.com/apache/celeborn/blob/a2110568f279c2714600b31e05708b7cb76e9936/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala#L323 When OOM is thrown, buf.readableBytes should be calculated as if no exception was thrown, because buf has been added to flushBuffer. I submitted some new commits to this end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
