codenohup commented on code in PR #3272:
URL: https://github.com/apache/celeborn/pull/3272#discussion_r2101767738
##########
client-flink/flink-1.16/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleServiceFactory.java:
##########
@@ -35,15 +36,21 @@ public ShuffleEnvironment<ResultPartitionWriter,
IndexedInputGate> createShuffle
ShuffleEnvironmentContext shuffleEnvironmentContext) {
AbstractRemoteShuffleServiceParameters parameters =
initializePreCreateShuffleEnvironment(shuffleEnvironmentContext);
+ ShuffleIOMetricGroup<?> metricGroup =
+ new
ShuffleIOMetricGroup<>(shuffleEnvironmentContext.getParentMetricGroup());
Review Comment:
It is advisable to use the task I/O metric as the parent metric instead of
the taskmanager metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
