RexXiong commented on code in PR #3256:
URL: https://github.com/apache/celeborn/pull/3256#discussion_r2115435525
##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGateDelegation.java:
##########
@@ -260,8 +261,10 @@ private Consumer<Throwable>
getFailureListener(ResultPartitionID rpID) {
if (cause != null) {
return;
}
- Class<?> clazz = PartitionUnRetryAbleException.class;
- if (throwable.getMessage() != null &&
throwable.getMessage().contains(clazz.getName())) {
+ String message = throwable.getMessage();
+ if (message != null
+ && (message.contains(CelebornIOException.class.getName())
Review Comment:
Celeborn worker throw a PartitionUnRetryAbleException when it determines
that a file is unreadable or does not exist; otherwise, the client should retry
for CelebornIOException. So if we can clearly identify these cases, we can
directly convert them to PartitionUnRetryAbleException. (In addition we already
have `PartitionConnectionException` for client-worker connection problem.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
