gauravkm commented on code in PR #3261:
URL: https://github.com/apache/celeborn/pull/3261#discussion_r2141716625
##########
client/src/main/java/org/apache/celeborn/client/read/CelebornInputStream.java:
##########
@@ -721,6 +740,36 @@ public synchronized void close() {
}
}
+ void validateIntegrity() throws IOException {
+ if (integrityChecked || !shuffleIntegrityCheckEnabled) {
+ return;
+ }
+
+ if (readSkewPartitionWithoutMapRange) {
+ shuffleClient.readReducerPartitionEnd(
Review Comment:
The existing Celeborn implementation in `CelebornInputStream` explicitly
sets the `startMapIndex` and `endMapIndex` to -1 in the case of
`skewPartitionHandlingWithoutMapRange`. That is why i left the existing
convention alone.
Would you know why the original implementation chose to set the values to -1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
