RexXiong commented on code in PR #3323:
URL: https://github.com/apache/celeborn/pull/3323#discussion_r2144363002
##########
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java:
##########
@@ -117,4 +118,38 @@ default DynamicConfig getTenantUserConfigFromCache(String
tenantId, String userI
/** Shutdowns configuration management service. */
void shutdown();
+
+ /**
+ * Upsert the system level dynamic configurations of {@link SystemConfig}.
+ *
+ * @param systemConfigs The system level dynamic configurations to upsert.
+ */
+ void upsertSystemConfig(Map<String, String> systemConfigs);
+
+ /**
+ * Upsert the tenant or tenant user level dynamic configurations of {@link
TenantConfig}.
+ *
+ * @param tenantId The tenant id to upsert.
+ * @param userId The user id to upsert.
+ * @param tenantConfigs The tenant or tenant user level dynamic
configurations to upsert.
+ */
+ void upsertTenantConfig(String tenantId, String userId, Map<String, String>
tenantConfigs);
+
+ /**
+ * Delete the system level dynamic configurations of {@link SystemConfig} by
config keys.
+ *
+ * @param configKeys The config keys of system level dynamic configurations
to delete.
+ */
+ void deleteSystemConfigByKeys(List<String> configKeys);
+
+ /**
+ * Delete the tenant or tenant user level dynamic configurations of {@link
TenantConfig} by config
+ * keys.
+ *
+ * @param tenantId The tenant id to delete.
+ * @param userId The user id to delete.
+ * @param configKeys The config keys of tenant or tenant user level dynamic
configurations to
+ * delete.
+ */
+ void deleteTenantConfigByKeys(String tenantId, String userId, List<String>
configKeys);
Review Comment:
void deleteTenantConfigByKeys(String tenantId, ConfigLevel level, String
name, List<String> configKeys);
##########
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java:
##########
@@ -117,4 +118,38 @@ default DynamicConfig getTenantUserConfigFromCache(String
tenantId, String userI
/** Shutdowns configuration management service. */
void shutdown();
+
+ /**
+ * Upsert the system level dynamic configurations of {@link SystemConfig}.
+ *
+ * @param systemConfigs The system level dynamic configurations to upsert.
+ */
+ void upsertSystemConfig(Map<String, String> systemConfigs);
+
+ /**
+ * Upsert the tenant or tenant user level dynamic configurations of {@link
TenantConfig}.
+ *
+ * @param tenantId The tenant id to upsert.
+ * @param userId The user id to upsert.
+ * @param tenantConfigs The tenant or tenant user level dynamic
configurations to upsert.
+ */
+ void upsertTenantConfig(String tenantId, String userId, Map<String, String>
tenantConfigs);
Review Comment:
`void upsertTenantConfig(String tenantId, String userId, Map<String, String>
tenantConfigs);` -> `void upsertTenantConfig(String tenantId, ConfigLevel
level, String name, Map<String, String> tenantConfigs);`
##########
service/src/main/java/org/apache/celeborn/server/common/service/store/IServiceManager.java:
##########
@@ -37,4 +38,12 @@ public interface IServiceManager {
List<ClusterSystemConfig> getSystemConfig();
List<ClusterTag> getClusterTags();
+
+ void upsertSystemConfig(Map<String, String> systemConfigs);
+
+ void upsertTenantConfig(String tenantId, String userId, Map<String, String>
tenantConfigs);
Review Comment:
useId -> name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
