Jraaay commented on PR #3330: URL: https://github.com/apache/celeborn/pull/3330#issuecomment-2994656250
> This won't be a problem because the OneWayMessageResponse won't be sent by the transport message via the network. Remove the conversion between the transport messages, and the following message conversions can be better. The following messages: PbCheckForWorkerTimeoutOrBuilder, CheckForApplicationTimeOut, CheckForDFSExpiredDirsTimeout, RemoveExpiredShuffle While this may be a convention, the code doesn't check for a null payload. Since a null payload is valid for a TransportMessage, I argue that its toByteBuffer method must handle this case to guarantee code robustness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
