gaoyajun02 commented on code in PR #3261:
URL: https://github.com/apache/celeborn/pull/3261#discussion_r2161633990
##########
client/src/main/java/org/apache/celeborn/client/read/CelebornInputStream.java:
##########
@@ -721,6 +740,36 @@ public synchronized void close() {
}
}
+ void validateIntegrity() throws IOException {
+ if (integrityChecked || !shuffleIntegrityCheckEnabled) {
+ return;
+ }
+
+ if (readSkewPartitionWithoutMapRange) {
+ shuffleClient.readReducerPartitionEnd(
Review Comment:
> > I propose we keep this as is for now. If required, we can always make a
smaller change in a follow up PR. Will make it easier to reason about as well
>
> Agree, this can be done in next prs
Agree +1, During the earliest review, we internally discussed the same issue
and hoped to use (int startMapIndex, int endMapIndex), but we need to confirm
the considerations of the previous code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
