SteNicholas commented on code in PR #3345:
URL: https://github.com/apache/celeborn/pull/3345#discussion_r2165424734


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/profiler/JVMProfiler.scala:
##########
@@ -77,4 +82,24 @@ class JVMProfiler(conf: CelebornConf) extends Logging {
       })
     }
   }
+
+  private def extractionDir: Path = {
+    val extractionDirectory = applicationsDir
+    if (extractionDirectory.toFile.exists()) {
+      extractionDirectory
+    } else {
+      Utils.createTempDir(conf.workerWorkingDir, "profiler").toPath

Review Comment:
   @turboFei, this could be `conf.workerWorkingDir/profiler`, but creating temp 
directory could avoid conflict of extracted libraries like version upgrade.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to