FMX commented on code in PR #3362:
URL: https://github.com/apache/celeborn/pull/3362#discussion_r2196952054


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/WorkerSource.scala:
##########
@@ -195,6 +200,10 @@ object WorkerSource {
   val COMMIT_FILES_TIME = "CommitFilesTime"
   val COMMIT_FILES_FAIL_COUNT = "CommitFilesFailCount"
   val FLUSH_WORKING_QUEUE_SIZE = "FlushWorkingQueueSize"
+  val LOCAL_FLUSH_BYTES_COUNT = "LocalFlushBytesCount"

Review Comment:
   These variable names are not proper. If you want to record the count of 
flush calls, you should use names like `LocalFlushCount` rather than 
`LocalFlushBytesCount`.
   In the meantime, if you are interested, you can also record the total flush 
bytes for each tier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to