Kalvin2077 commented on code in PR #3353:
URL: https://github.com/apache/celeborn/pull/3353#discussion_r2227852269
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -165,6 +157,7 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
(flushers, totalThread)
}
+ // TODO
Review Comment:
I once wanted to refactor the following code, but now I think it is too
cumbersome. I will remove the `TODO` tag in the next commit.
Before that, I'll test the improvement of this PR on the cluster instead of
only relying on unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
