RexXiong commented on code in PR #3395:
URL: https://github.com/apache/celeborn/pull/3395#discussion_r2238620668
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/FlushTask.scala:
##########
@@ -65,20 +65,39 @@ private[worker] class LocalFlushTask(
}
}
+abstract private[worker] class DfsFlushTask(
+ buffer: CompositeByteBuf,
+ notifier: FlushNotifier,
+ keepBuffer: Boolean,
+ source: AbstractSource) extends FlushTask(buffer, notifier, keepBuffer,
source) {
+ def flush(stream: Closeable)(block: => Unit): Unit = {
+ try {
+ block
+ } finally {
+ try {
+ stream.close()
+ } catch {
+ case _: IOException =>
Review Comment:
better log the exception~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
