turboFei commented on code in PR #3401:
URL: https://github.com/apache/celeborn/pull/3401#discussion_r2243870849
##########
client-spark/common/src/main/scala/org/apache/celeborn/spark/FailedShuffleCleaner.scala:
##########
@@ -85,9 +67,24 @@ private[celeborn] class
FailedShuffleCleaner(lifecycleManager: LifecycleManager)
init()
+ def addShuffleIdToBeCleaned(appShuffleIdentifier: String): Unit = {
+ val Array(appShuffleId, _, _) =
SparkCommonUtils.decodeAppShuffleIdentifier(
+ appShuffleIdentifier)
+ lifecycleManager.getShuffleIdMapping.get(appShuffleId.toInt).foreach {
+ case (_, (celebornShuffleId, _)) =>
shufflesToBeCleaned.put(celebornShuffleId)
+ }
+ }
Review Comment:
just reorder the methods to make it much clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
