HolyLow commented on code in PR #3402:
URL: https://github.com/apache/celeborn/pull/3402#discussion_r2246764793
##########
cpp/celeborn/client/reader/CelebornInputStream.h:
##########
@@ -68,6 +70,10 @@ class CelebornInputStream {
int attemptNumber_;
int startMapIndex_;
int endMapIndex_;
+ bool shouldDecompress_;
+ std::unique_ptr<compress::Decompressor> decompressor_;
+ std::vector<char> rawDataBuf_;
Review Comment:
Use uint8_t might be slightly better than using char. char is not a
well-defined type as it might be signed in some compilers while unsigned in
others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
