RexXiong commented on code in PR #3417:
URL: https://github.com/apache/celeborn/pull/3417#discussion_r2281636645
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -1147,6 +1147,15 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
} else if (dirs.nonEmpty &&
location.getStorageInfo.localDiskAvailable()) {
val dir = dirs(getNextIndex % dirs.size)
val mountPoint = DeviceInfo.getMountPoint(dir.getAbsolutePath,
mountPoints)
+ val flusher = localFlushers.get(mountPoint)
+ val diskFull = checkDiskFull(flusher)
Review Comment:
Should we let celeborn worker retry other disks? Seems Only throw Exception
eg:`CelebornDiskFullException` is enough for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
