turboFei commented on code in PR #3428:
URL: https://github.com/apache/celeborn/pull/3428#discussion_r2298362996
##########
common/src/main/scala/org/apache/celeborn/common/util/PbSerDeUtils.scala:
##########
@@ -198,8 +199,13 @@ object PbSerDeUtils {
PbFileInfoMap.newBuilder.putAllValues(pbFileInfoMap).build.toByteArray
}
- def fromPbUserIdentifier(pbUserIdentifier: PbUserIdentifier): UserIdentifier
=
- UserIdentifier(pbUserIdentifier.getTenantId, pbUserIdentifier.getName)
+ def fromPbUserIdentifier(pbUserIdentifier: PbUserIdentifier): UserIdentifier
= {
+ if (StringUtils.isAllEmpty(pbUserIdentifier.getTenantId,
pbUserIdentifier.getName)) {
+ UserIdentifier.UNKNOWN
Review Comment:
<img width="1220" height="317" alt="image"
src="https://github.com/user-attachments/assets/f047041f-3cbd-4740-987e-034e3c37db98";
/>
Incase the fromPbUserIdentifier failed for `DEFAULT_INSTANCE` if
pbUserIdentifier is null.
https://github.com/apache/celeborn/blob/a9490d6e24683e5f7a6526fff027600676913963/common/src/main/scala/org/apache/celeborn/common/identity/UserIdentifier.scala#L28-L31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
