FMX commented on code in PR #3471:
URL: https://github.com/apache/celeborn/pull/3471#discussion_r2352610020
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/quota/QuotaManager.scala:
##########
@@ -339,12 +350,14 @@ class QuotaManager(
var nonExpired = used
if (checkConsumptionExceeded(used, threshold)) {
val sortedConsumption =
- appMap.sortBy(_._2)(Ordering.by((r: ResourceConsumption) =>
- (
- r.diskBytesWritten,
- r.diskFileCount,
- r.hdfsBytesWritten,
- r.hdfsFileCount)).reverse)
+ appMap.filter(app =>
+ appQuotaConfig.getOrDefault(app._1,
defaultQuotaConfig).quotaInterruptShuffleEnabled)
Review Comment:
Seems that you only used the `quotaInterruptShuffleEnabled` in the expire
application method, why not respect it in the `interruptShuffleEnabled` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
