SteNicholas commented on code in PR #3486:
URL: https://github.com/apache/celeborn/pull/3486#discussion_r2425300129
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -634,16 +634,20 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
logInfo(s"Cleanup expired shuffle $shuffleKey.")
if (diskFileInfos.containsKey(shuffleKey)) {
val removedFileInfos = diskFileInfos.remove(shuffleKey)
- var isDfsExpired = false
- var isHdfs = false
- var isOss = false
+ var hdfsFilesExpired = false
Review Comment:
We could introduce `storageType` variable to set via `fileInfo`. Then this
variable could be used in `StorageManager.hadoopFs.get`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
